LibSSH+SSHServer: Enough to run commands over the network#26684
Merged
nico merged 2 commits intoSerenityOS:masterfrom Mar 24, 2026
Merged
LibSSH+SSHServer: Enough to run commands over the network#26684nico merged 2 commits intoSerenityOS:masterfrom
nico merged 2 commits intoSerenityOS:masterfrom
Conversation
This implementation allows any authentication from the current user with the `none` method. It is a MAJOR SECURITY HOLE, use at your own risk. Other authentication methods should be added soon to solve this issue.
github-actions
bot
added
the
👀 pr-needs-review
spholz
reviewed
Mar 24, 2026
This allows a client to execute commands on the server. This is very minimal and don't support interactive sessions yet. It is however enough to run simple commands like `uname` over the network :^)
LucasChollet
force-pushed
the
ssh-server-5
branch
from
e2f6e66 to
4878bac
Compare
nico
reviewed
Mar 24, 2026
| return Error::from_string_literal("Can't authenticate for another user account"); | ||
|
|
||
| if (method_name == "none"sv.bytes()) { | ||
| // FIXME: Implement proper authentication!!! |
Contributor
There was a problem hiding this comment.
nit: Add dbgln("MAJOR SECURITY HOLE: Accepting without auth; add actual auth support soon"); maybe?
nico
approved these changes
Mar 24, 2026
github-actions
bot
removed
the
👀 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see it in action inside Serenity here, and it also works on Lagom:
OpenSSH clients send multiple CHANNEL_REQUEST packets at the same time, so in practice this depends on #26683.